chore(deps): migrate from eventide to kotatsu - #428

cmake/package.cmake (1)

42-56: Consider pinning kotatsu to a commit or tag.

GIT_TAG main leaves the build subject to upstream drift and makes bisection harder. Since the PR notes a specific dependency on clice-io/kotatsu#110, pinning to that merge commit (or a release tag) would make builds reproducible without changing behavior today.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmake/package.cmake` around lines 42 - 56, The FetchContent entry for kotatsu
currently uses GIT_TAG main which allows upstream drift; replace the GIT_TAG
main line with a pinned commit hash or explicit release tag (the merge commit
for clice-io/kotatsu#110 or a released tag) so builds are reproducible — e.g.
update the kotatsu block (the lines that include kotatsu, GIT_REPOSITORY,
GIT_TAG main, GIT_SHALLOW TRUE) to use the chosen commit hash/tag instead of
"main" and keep FetchContent_MakeAvailable(kotatsu spdlog croaring flatbuffers)
as-is.

src/syntax/dependency_graph.cpp (1)

793-801: Nit: adjacent string literals look incidental.

The format string is split as "... next={} " "prefetch={}", which concatenates fine (7 placeholders, 7 args). It's unrelated to this migration, but if you happen to touch this line again, consider collapsing it into a single literal for readability.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/syntax/dependency_graph.cpp` around lines 793 - 801, The LOG_INFO call
currently uses two adjacent string literals ("... next={} " "prefetch={}") which
accidentally splits the format string; update the LOG_INFO invocation (the
format string in the LOG_INFO call near wave_num/current_wave/prefetch_tasks) to
use a single contiguous literal for readability (e.g., collapse into "...
next={} prefetch={}") while keeping the same placeholders and arguments
(wave_num, current_wave.size(), p1, p2, p3, next_wave.size(),
prefetch_tasks.size()).

src/server/worker_common.h (1)

10-13: LGTM — to_raw migrated cleanly.

The three new kota includes match the types used, and the template now returns kota::codec::RawValue via kota::codec::json::to_json<kota::ipc::lsp_config> with the same "null" fallback as before. The mirror copy in src/server/master_server.cpp (L33-37) is consistent.

Side note (not blocking): the to_raw helper is duplicated between this header and master_server.cpp. Since this header is included by both stateful_worker.cpp and stateless_worker.cpp, master_server.cpp could also just include worker_common.h and drop its static copy — worth a small follow-up cleanup if you want to consolidate.

Also applies to: 40-42

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/server/worker_common.h` around lines 10 - 13, The to_raw helper (which
returns kota::codec::RawValue via
kota::codec::json::to_json<kota::ipc::lsp_config> with the "null" fallback) is
duplicated in this header and in master_server.cpp; remove the static copy in
master_server.cpp and have master_server.cpp include worker_common.h instead so
there is a single to_raw implementation (ensure includes for
kota::codec::json::serializer, kota::codec::raw_value and kota::ipc::codec::json
remain available where to_raw is used).

src/server/compiler.cpp (2)

26-26: Rename the serde_raw alias to reflect the new codec terminology.

Since this PR renames eventide::serde → kota::codec project-wide, carrying a serde_raw alias forward is misleading to readers. Consider renaming (e.g. raw_value / codec_raw) for consistency with the new naming.

✏️ Proposed rename

-using serde_raw = kota::codec::RawValue;
+using raw_value = kota::codec::RawValue;

(All serde_raw{...} usages below would need to be updated to match.)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/server/compiler.cpp` at line 26, Rename the misleading alias serde_raw to
a name matching the kota::codec terminology (e.g., raw_value) by changing the
alias declaration using serde_raw = kota::codec::RawValue; to using raw_value =
kota::codec::RawValue; and update all references of serde_raw throughout the
codebase (including uses in src/server/compiler.cpp and any other files) to
raw_value so the alias matches the new codec naming. Ensure you also update any
comments or docstrings that mention serde_raw to reflect the new name.

---

897-913: Inline JSON serialization duplicates worker_common.h::to_raw.

Both completion branches here replicate exactly the body of to_raw (from src/server/worker_common.h) but fall back to "[]" instead of "null". Consider extending to_raw to accept a fallback (or adding a to_raw_array helper) so these two sites can call the shared helper — reducing duplication and keeping the lsp_config plumbing in one place.

♻️ Sketch

// in worker_common.h
template <typename T>
inline kota::codec::RawValue to_raw(const T& value, std::string_view fallback = "null") {
    auto json = kota::codec::json::to_json<kota::ipc::lsp_config>(value);
    return kota::codec::RawValue{json ? std::move(*json) : std::string(fallback)};
}

-            auto json = kota::codec::json::to_json<kota::ipc::lsp_config>(items);
-            co_return serde_raw{json ? std::move(*json) : "[]"};
+            co_return to_raw(items, "[]");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/server/compiler.cpp` around lines 897 - 913, The two completion branches
in compiler.cpp duplicate the JSON serialization logic found in worker_common.h;
update the shared helper (either extend to_raw in worker_common.h to accept a
fallback std::string_view or add a new to_raw_array helper) so it performs
kota::codec::json::to_json<kota::ipc::lsp_config>(...) and returns a
kota::codec::RawValue with the given fallback when json is null, then replace
the duplicated blocks in the Completion and CompletionContext::Import branches
to call the new helper (ensuring the Import branch uses fallback "[]") instead
of inlining the serialization.